[PWGHF] First draft of Omegac0 to OmegaPi QA workflow by mtorresc15 · Pull Request #18126 · AliceO2Group/O2Physics

mtorresc15 · 2026-09-30T16:04:07Z

First draft of the QA workflow for the Omegac0 to OmegaPi analysis.

This PR introduces dedicated QA versions of the candidate selector, tree creator, analysis task, and ML response to allow a more detailed validation of the Omegac0 to OmegaPi analysis workflow.

The main additions are:

Candidate selector: QA monitoring of the selection steps, with dedicated DCAFitter and KFParticle processing.
Tree creator: dedicated QA output tables containing additional reconstruction and selection information for DCAFitter and KFParticle candidates.
ML response: common and reconstruction-specific ML input features for both DCAFitter and KFParticle.
Analysis task: processing DCAFitter and KFParticle candidates, with and without ML selections.

The implementation is based on the existing Omegac0 to OmegaPi analysis workflow and is intended to facilitate validation and comparison of the DCAFitter and KFParticle reconstruction and selection strategies.

This PR is opened as a draft for preliminary review and feedback.

github-actions · 2026-09-30T16:04:27Z

O2 linter results: ❌ 0 errors, ⚠️ 3 warnings, 🔕 0 disabled

Copilot

Copilot review overview

🟡 Changes recommended

The new executables lack build registration, and selector issues can alter cuts or fatally terminate ML workflows.

Review effort: Balanced
Findings: 4 · 2 · 1

Open (7)

Register QA analysis task source in CMake · New
Guard ML inference for out-of-range candidate pT · New
Register QA selector source in CMake · New
Register QA tree creator source in CMake · New
Use normalized V0 chi-square for threshold cuts · New
Apply configurable pT-dependent bachelor-pion cuts · New
Correct documentation to describe neutral Omegac decay · New

What changed in this PR

Adds QA workflows for comparing DCAFitter and KFParticle Ωc⁰→Ωπ reconstruction.

Changes:

Adds QA candidate selection and output trees.
Adds reconstruction-specific ML features.
Adds data/MC analysis modes with optional ML and centrality.

File	Description
`PWGHF/TableProducer/treeCreatorOmegac0ToOmegaPiQa.cxx`	Defines detailed QA output tables.
`PWGHF/TableProducer/candidateSelectorOmegac0ToOmegaPiQa.cxx`	Implements selection, PID, ML, and QA monitoring.
`PWGHF/D2H/Tasks/taskOmegac0ToOmegaPiQa.cxx`	Adds data and MC analysis modes.
`PWGHF/Core/HfMlResponseOmegacToOmegaPiQa.h`	Defines DCAFitter and KFParticle ML features.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

fcatalan92 · 2026-10-06T13:26:45Z

+    inputFeatures.emplace_back(candidate.GETTER());                  \
+    break;                                                           \
+  }
+namespace o2::analysis


Suggested change

namespace o2::analysis

namespace o2::analysis

fcatalan92 · 2026-10-06T13:41:18Z

+  // Mass window
+  Configurable<double> v0MassWindow{"v0MassWindow", 0.01, "V0 mass window"};
+  Configurable<double> cascadeMassWindow{"cascadeMassWindow", 0.01, "Cascade mass window"};
+  Configurable<double> invMassCharmBaryonMin{"invMassCharmBaryonMin", 2.3, "Lower limit invariant mass spectrum charm baryon"}; // 2.4 Omegac0 only


Suggested change

Configurable<double> invMassCharmBaryonMin{"invMassCharmBaryonMin", 2.3, "Lower limit invariant mass spectrum charm baryon"}; // 2.4 Omegac0 only

Configurable<double> invMassCharmBaryonMin{"invMassCharmBaryonMin", 2.3, "Lower limit invariant mass spectrum charm baryon"};

fcatalan92 · 2026-10-06T13:43:18Z

+  Configurable<bool> usePidTpcOnly{"usePidTpcOnly", false, "Perform PID using only TPC"};
+  Configurable<bool> usePidTpcTofCombined{"usePidTpcTofCombined", true, "Perform PID using TPC & TOF"};


Suggested change

Configurable<bool> usePidTpcOnly{"usePidTpcOnly", false, "Perform PID using only TPC"};

Configurable<bool> usePidTpcTofCombined{"usePidTpcTofCombined", true, "Perform PID using TPC & TOF"};

Configurable<bool> usePidTpcOnly{"usePidTpcOnly", true, "Perform PID using only TPC"};

Configurable<bool> usePidTpcTofCombined{"usePidTpcTofCombined", false, "Perform PID using TPC or TOF"};

fcatalan92 · 2026-10-06T13:49:42Z

+    // registry.add("hSelMassLam", "hSelMassLam;status;entries", {HistType::kTH1D, {axisSel}});
+    // registry.add("hSelMassCasc", "hSelMassCasc;status;entries", {HistType::kTH1D, {axisSel}});
+    // registry.add("hSelMassCharmBaryon", "hSelMassCharmBaryon;status;entries", {HistType::kTH1D, {axisSel}});


Suggested change

// registry.add("hSelMassLam", "hSelMassLam;status;entries", {HistType::kTH1D, {axisSel}});

// registry.add("hSelMassCasc", "hSelMassCasc;status;entries", {HistType::kTH1D, {axisSel}});

// registry.add("hSelMassCharmBaryon", "hSelMassCharmBaryon;status;entries", {HistType::kTH1D, {axisSel}});

fcatalan92 · 2026-10-06T13:56:10Z

+    // Distance of Closest Approach(DCA)
+    if (candidate.dcaV0Dau() > dcaV0DauMax) {
+      return false;
+    }
+    registry.fill(HIST("hSelStatusLf"), 8.0);
+
+    if (candidate.dcaCascDau() > dcaCascDauMax) {
+      return false;
+    }


Are these two quantities always positive?

fcatalan92 · 2026-10-06T14:23:15Z

+  using MyEventTable = soa::Join<aod::Collisions, aod::EvSels>;
+  using MyEventTableWithFT0M = soa::Join<aod::Collisions, aod::EvSels, aod::CentFT0Ms>;


Suggested change

using MyEventTable = soa::Join<aod::Collisions, aod::EvSels>;

using MyEventTableWithFT0M = soa::Join<aod::Collisions, aod::EvSels, aod::CentFT0Ms>;

using MyEventTable = soa::Join<aod::Collisions, aod::EvSels>;

using MyEventTableWithFT0M = soa::Join<aod::Collisions, aod::EvSels, aod::CentFT0Ms>;

Use proper names for these two tables, e.g., CollsSel

fcatalan92 · 2026-10-06T14:25:55Z

+      } else {
+        // Not available yet
+      }


Suggested change

} else {

// Not available yet

}

}

fcatalan92 · 2026-10-06T14:34:28Z

+  Produces<o2::aod::HfOmegac0ToOmegaPiLites> rowCandidateLite;
+  Produces<o2::aod::HfKfOmegacFulls> rowKfCandidateFull;
+  Produces<o2::aod::HfKfOmegacLites> rowKfCandidateLite;


I would have only one table for the DCA method and one for the KFParticle one

fcatalan92 · 2026-10-06T14:36:54Z

+  }
+
+  template <int svReco, int tableSize, bool useCentrality, typename MyEventTableType, typename T>
+  void fillCandidate(const T& candidate, int8_t flagMc, int8_t originMc, bool collisionMatched, float centrality = -999.f)


Here all the particles are filled in the tree, without checking if the particle pass the selections. Please have a look at how to implement the check to select only candidates passing the cuts. You can also do that with a filter on the table.

mtorresc15 added 11 commits September 9, 2026 12:31

Update QA candidate selector for Omegac0

d9fc6bc

Update QA candidate selector for Omegac0

8434aa9

Fix bugs in QA candidate selector for Omegac0

4ab3779

Update OmegaC candidate selector QA

3bc0ba8

First draft for OmegaC tree creator QA

3c24dab

Add OmegaC QA task

3fedfd7

Add OmegaC ML response QA header

7ae589e

Update on OmegaC ML response QA header

bd07df0

Update OmegaC QA task

b3cf2b2

Extend Omegac QA ML support to DCAFitter

a793db1

Refine Omegac QA ML implementation

6a4c788

github-actions Bot added the pwghf PWG-HF label Sep 30, 2026

github-actions Bot changed the title ~~First draft of Omegac0 to OmegaPi QA workflow~~ [PWGHF] First draft of Omegac0 to OmegaPi QA workflow Sep 30, 2026

alibuild mentioned this pull request Sep 30, 2026

Please consider the following formatting changes to #18126 mtorresc15/O2Physics#6

Closed

Fix formatting issues in Omegac QA workflow

988a58a

fcatalan92 requested a balanced review from Copilot October 1, 2026 16:19

Copilot started reviewing on behalf of fcatalan92 October 1, 2026 16:19 View session

Copilot AI reviewed Oct 1, 2026

View reviewed changes

mtorresc15 added 2 commits October 1, 2026 13:50

Fix Omegac QA selections and DCA rapidity

d00fd34

Fix Omegac QA selections and clean up obsolete code

930c0db

alibuild mentioned this pull request Oct 5, 2026

Please consider the following formatting changes to #18126 mtorresc15/O2Physics#7

Closed

Fix clang-format in Omegac QA tree creator

49f2a15

fcatalan92 reviewed Oct 6, 2026

View reviewed changes

	Configurable<double> invMassCharmBaryonMin{"invMassCharmBaryonMin", 2.3, "Lower limit invariant mass spectrum charm baryon"}; // 2.4 Omegac0 only
	Configurable<double> invMassCharmBaryonMin{"invMassCharmBaryonMin", 2.3, "Lower limit invariant mass spectrum charm baryon"};

		Configurable<bool> usePidTpcOnly{"usePidTpcOnly", false, "Perform PID using only TPC"};
		Configurable<bool> usePidTpcTofCombined{"usePidTpcTofCombined", true, "Perform PID using TPC & TOF"};

	// registry.add("hSelMassLam", "hSelMassLam;status;entries", {HistType::kTH1D, {axisSel}});
	// registry.add("hSelMassCasc", "hSelMassCasc;status;entries", {HistType::kTH1D, {axisSel}});
	// registry.add("hSelMassCharmBaryon", "hSelMassCharmBaryon;status;entries", {HistType::kTH1D, {axisSel}});

		using MyEventTable = soa::Join<aod::Collisions, aod::EvSels>;
		using MyEventTableWithFT0M = soa::Join<aod::Collisions, aod::EvSels, aod::CentFT0Ms>;

Conversation

mtorresc15 commented Sep 30, 2026

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants